fix: restore mxDictionary map index signature parameter set to string #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error TS1023: An index signature parameter type must be either 'string' or 'number'. In addition, references to mxgraph javascript code is available to explain why the key is a string. `skipLibCheck` is now set to `false` in the tsconfig.json file. So, tsc run prior checking the tests will fail in case of TS errors and we will be alerted before integrating such problem in the repository. Projects integrating typed-mxgraph will also be able to use this option without errors coming from the mxgraph types.
|
This has been introduced in #31 by myself, sorry for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error TS1023: An index signature parameter type must be either 'string' or
'number'. In addition, references to mxgraph javascript code is available to
explain why the key is a string.
skipLibCheckis now set tofalsein the tsconfig.json file. So, tsc runprior checking the tests will fail in case of TS errors and we will be alerted
before integrating such problem in the repository.
Projects integrating typed-mxgraph will also be able to use this option without
errors coming from the mxgraph types.