added links to several typing-related PEPs #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested changes
May 18, 2020
README.md
Outdated
| - [PEP-612](https://www.python.org/dev/peps/pep-0612/) - Parameter Specification Variables | ||
| - [PEP-613](https://www.python.org/dev/peps/pep-0613/) - Explicit Type Aliases | ||
|
|
||
| (*) these PEPs are mentioned on the first paragraph of the [typing](https://docs.python.org/3/library/typing.html) module documenation, so they may be the best places to start. |
There was a problem hiding this comment.
I would say it is safe to remove this mark.
There was a problem hiding this comment.
OK, I will remove it.
|
There's also a failing CI, can you please fix it? |
|
I've removed the (*) as you requested.
The CI doesn't tell me what's the problem, and I see nothing wrong in my fork rendered by Github: https://github.com/ramalho/awesome-python-typing#peps Thanks for any help addressing the CI issue. |
|
Oh, I see. The error message is not clear indeed. There are two problems:
Big thanks! 👍 |
|
Thanks, I will fix both issues. Please tell me the messages appear. I
couldn’t find them at all. Thanks !
On Tue, 19 May 2020 at 04:23 Nikita Sobolev ***@***.***> wrote:
Oh, I see. The error message is not clear indeed.
There are two problems:
1. You are not using . to end the list item description and our linter
requires that
2. (unrelated) https://github.com/lyft/pynamodb-mypy link is dead, can
you please also remove it?
Big thanks! 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAHJ6DEOVLKDCL5GUKHQADRSIXYLANCNFSM4NENDA6Q>
.
--
Luciano Ramalho
| Author of Fluent Python (O'Reilly, 2015)
| http://shop.oreilly.com/product/0636920032519.do
| Technical Principal at ThoughtWorks
| Twitter: @ramalhoorg
|
Yes, the do! Thanks a lot for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds links to 11 additional PEPs related to type hints in Python.
I also changed the description of the previous links to the actual titles of the PEPs, which will make this list easier to maintain as new PEPs are added.
Finally, I included an asterisk (*) and an explanation about PEPs that may be more important for people getting started, as they are specifically mentioned in the first paragraph of the typing module documenation.