Use _AsSqlType for as_sql
#1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its subclasses inherits the type annotation from `SpatialOperator`, so copying `as_sql` over is unnecessary. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
`Query` inherits `as_sql` from `BaseExpression`, `GISLookup` inherits `as_sql` from `Lookup`, and `BuiltinLookup` inherits `as_sql` from `Lookup[_T]`. None is required to be redefined. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
`Tuple[str, _ParamsT]`, `Tuple[str, List[Union[str, int]]]` and other similar type annotations are all replaced with the `_AsSqlType` alias. Any as_sql definition that annotate the return type as `Any` is also updated to use `_AsSqlType`. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
This series of changes enhance the stubs by reusing the
_AsSqlTypetype alias to annotate the return type ofas_sql.