Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BaseDetailView.object #1211

Merged
merged 1 commit into from Oct 27, 2022
Merged

Add BaseDetailView.object #1211

merged 1 commit into from Oct 27, 2022

Conversation

adamchainz
Copy link
Contributor

I have made things!

Django source: https://github.com/django/django/blob/84206607d6bfd61e7f7a88b51163ffd4153e3b5a/django/views/generic/detail.py#L108

A bit weird it's not in SingleObjectMixin, which references it, but whatever, that needs fixing in Django.

Related issues

Fixes #605.

@adamchainz adamchainz mentioned this pull request Oct 27, 2022
Closed
sobolevn
sobolevn approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sobolevn sobolevn merged commit ae5af12 into typeddjango:master Oct 27, 2022
@adamchainz adamchainz deleted the base_detail_view_object branch October 27, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DetailView has no attribute "object"
2 participants
@adamchainz @sobolevn