BaseDeleteView now extends FormMixin #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Simon Kohlmeyer <simon.kohlmeyer@gmail.com>
adamchainz
force-pushed
the
base_delete_view
branch
from
38c9777
to
3e16fa6
Compare
sobolevn
reviewed
Oct 28, 2022
django-stubs/views/generic/edit.pyi
Outdated
| @@ -66,9 +66,9 @@ class DeletionMixin(Generic[_M]): | |||
| def delete(self, request: HttpRequest, *args: Any, **kwargs: Any) -> HttpResponse: ... | |||
| def get_success_url(self) -> str: ... | |||
|
|
|||
| class BaseDeleteView(DeletionMixin[_M], BaseDetailView[_M]): | |||
| class BaseDeleteView(DeletionMixin[_M], FormMixin[_ModelFormT], BaseDetailView[_M]): | |||
There was a problem hiding this comment.
It is better to explicitly add Generic[_M, _ModelFormT] when two vars are used this way.
Otherwise, it is easy to mix things up.
There was a problem hiding this comment.
So, like the commit I just pushed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Fixed conflict version of #849.
Changed in Django 4.0: django/django@3a45fea
https://docs.djangoproject.com/en/4.0/releases/4.0/#generic-views
Related issues
Fixes #1214.