Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clean() to AbstractBaseUser #1283

Closed
wants to merge 1 commit into from
Closed

Add clean() to AbstractBaseUser #1283

wants to merge 1 commit into from

Conversation

Archmonger
Copy link

@Archmonger Archmonger commented Dec 6, 2022 •
edited
Loading

Discovered a missing definition while investigating #1282.

This technically might not be needed, but can be merged depending on if this repo prioritizes completeness.

Related issues

sobolevn
sobolevn reviewed Dec 6, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is defined in a super type:

django-stubs/django-stubs/db/models/base.pyi

Line 42 in b8a1dae

def clean(self) -> None: ...

@sobolevn
Copy link
Member

sobolevn commented Dec 6, 2022

I mean that all Model instances have clear method. So, any User would have clearn method from it.

@Archmonger Archmonger closed this Dec 6, 2022
@Archmonger Archmonger deleted the abstract-base-user-fields branch December 6, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Archmonger @sobolevn