Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash using .values_list("pk") on abstract model #1355

Merged
merged 1 commit into from Feb 7, 2023
Merged

Fix crash using .values_list("pk") on abstract model #1355

merged 1 commit into from Feb 7, 2023

Conversation

flaeppe
Copy link
Member

@flaeppe flaeppe commented Jan 31, 2023

Related issues

Closes: #1347
Ref: #1328

intgr
intgr requested changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the test tweak, looks good to me.

@flaeppe flaeppe requested a review from intgr February 7, 2023 20:47
intgr
intgr approved these changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@intgr intgr merged commit 0bb7dbb into typeddjango:master Feb 7, 2023
@flaeppe flaeppe deleted the fix/abstract-values-list branch February 7, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intgr intgr intgr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin crash on abstract model filtering with custom Manager
2 participants
@flaeppe @intgr