Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate BaseCreateView.object attribute as Model | None #1377

Merged
merged 2 commits into from Feb 23, 2023
Merged

Annotate BaseCreateView.object attribute as Model | None #1377

merged 2 commits into from Feb 23, 2023

Conversation

RyanWalker277
Copy link
Contributor

Related issues

Fixes #986

Code Changes

Specified a _M | None type for object attribute of BaseCreateView class

intgr
intgr approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks

@intgr intgr changed the title Fix#986: Incorrect BaseCreateView.object annotation Annotate BaseCreateView.object attribute as Model | None Feb 23, 2023
@intgr intgr merged commit 0e7270c into typeddjango:master Feb 23, 2023
@RyanWalker277 RyanWalker277 deleted the Fix#986 branch February 23, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intgr intgr intgr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect BaseCreateView.object annotation
2 participants
@RyanWalker277 @intgr