Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added stub for where method #1407

Merged
merged 2 commits into from Mar 20, 2023
Merged

Added stub for where method #1407

merged 2 commits into from Mar 20, 2023

Conversation

RyanWalker277
Copy link
Contributor

Added a stub for Query.where

Fixes #1399

Description

Added a new where attribute to the Query class definition. Hope it fixes this!

sobolevn
sobolevn approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed: https://github.com/django/django/blob/f9f9215d3e5500d9a8d0bec0936480ba34d42e88/django/db/models/sql/query.py#L250

Thanks!

@sobolevn sobolevn merged commit 5092bdf into typeddjango:master Mar 20, 2023
14 checks passed
@RyanWalker277 RyanWalker277 deleted the Fix#1399 branch March 20, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Query" has no attribute "where"
2 participants
@RyanWalker277 @sobolevn