Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Model methods, update AdminSite.get_app_list() args #1413

Merged
merged 3 commits into from Mar 25, 2023
Merged

Add missing Model methods, update AdminSite.get_app_list() args #1413

merged 3 commits into from Mar 25, 2023

Conversation

RyanWalker277
Copy link
Contributor

@RyanWalker277 RyanWalker277 commented Mar 25, 2023 •
edited

Refs

Fixes #1405

Changes

Added stubs for get_constraints, serializable_value, prepare_database_save and date_error_message. Also added app_label parameter in get_app_list

sobolevn
sobolevn reviewed Mar 25, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one suggestion

django-stubs/db/models/base.pyi Outdated Show resolved Hide resolved
@RyanWalker277
Copy link
Contributor Author

Thanks, one suggestion

Thanks for the help. 😄

@RyanWalker277
Copy link
Contributor Author

I have added one more change to fix #1405.

@sobolevn
Copy link
Member

Next time, please create separate PRs for unrelated changes, this way it is easier to review and track changes, revert them if needed.

Thank you for your help!

@sobolevn sobolevn merged commit 9da7b14 into typeddjango:master Mar 25, 2023
14 checks passed
@RyanWalker277 RyanWalker277 deleted the patch-1 branch April 4, 2023 13:00
@intgr intgr changed the title Added missing stubs Add missing Model methods, update AdminSite.get_app_list() args Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing app_label for AdminSite.get_app_list in stub
2 participants
@RyanWalker277 @sobolevn