Fix ForeignKey queryset filters for cases where the to argument is a … #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Apr 13, 2023
Sure! Apparently it has also broken a bunch of things, I will take a look into that. |
Kircheneer
force-pushed
the
fix-foreign-key
branch
from
faf0ce4
to
e9925e4
Compare
|
I have switched approaches here a little because I discovered this only applies when abstract base classes are involved. From the docs:
I have changed the logic to accommodate for this and added a test. |
sobolevn
reviewed
Apr 14, 2023
Kircheneer
force-pushed
the
fix-foreign-key
branch
from
8868b6a
to
d9e0136
Compare
…string like 'app_label.model_name'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…string like 'app_label.model_name'.
I have made things!
Related issues
Refs #626 (probably closes, but my use case is only similar, not exactly the same.
This fixes lookups for related_cls where it was assumed the
tofield on a foreign key would always be a class. If it is a string however (usingapp_label.model_namenotation), this breaks some things.