Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set/get typing for spatial Model Fields #1487

Merged
merged 1 commit into from May 11, 2023
Merged

Add set/get typing for spatial Model Fields #1487

merged 1 commit into from May 11, 2023

Conversation

martinlehoux
Copy link
Contributor

Related issues

@martinlehoux martinlehoux marked this pull request as ready for review May 10, 2023 18:01
intgr
intgr approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@intgr intgr changed the title feat(gis): Add set/get typing to contrib.gis fields Fix set/get typing for spacial Model Fields May 11, 2023
@intgr intgr changed the title Fix set/get typing for spacial Model Fields Add set/get typing for spacial Model Fields May 11, 2023
@intgr intgr merged commit 7c9d2f3 into typeddjango:master May 11, 2023
14 checks passed
@intgr
Copy link
Collaborator

intgr commented May 11, 2023

Any reason to omit ExtentField and RasterField? Looks like RasterField uses type GDALRaster, not sure what ExtentField is. Feel free to submit another PR 😉

@martinlehoux
Copy link
Contributor Author

I'd say the reason was that they don't look the same xD

@intgr intgr changed the title Add set/get typing for spacial Model Fields Add set/get typing for spatial Model Fields May 12, 2023
@martinlehoux
Copy link
Contributor Author

Weirdly, I can't seem to make this work in my project. CharField is well typed as str, but PointField wont get typed as Point. Any idea what could be different here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intgr intgr intgr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contrib.gis PointField typing
2 participants
@martinlehoux @intgr