Improve core.files.storages types for Django 4.2 #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
requested changes
May 15, 2023
intgr
changed the title
intgr
approved these changes
May 16, 2023
|
Ok, so it wasn鈥檛 actually so difficult to do that properly, and as this PR鈥痠s not merged yet, I鈥痶hink we should do it properly right away. The only part I鈥痺asn鈥檛 sure about was the typing of |
Oops, sorry, I was waiting for CI and forgot to merge afterwards. |
intgr
reviewed
May 26, 2023
|
No worries. The CI鈥痵eems to be green again after your commit, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 馃憢 ,
this PR鈥痠s adding types for the new storages concepts added in 4.2:
https://docs.djangoproject.com/en/4.2/ref/files/storage/#django.core.files.storage.storages
&
https://docs.djangoproject.com/en/4.2/ref/files/storage/#the-inmemorystorage-class
I didn鈥檛 find any tests for the existing storages concepts so didn鈥檛 add any. Let me know if you鈥檇 like for me to add some.