Fix overriding AppConfig.default_auto_field with string value #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
reviewed
Jun 28, 2023
christianbundy
approved these changes
Jun 28, 2023
|
We should make a release with this fix. Unfortunately, I have issues with my computer and won't be able to release a fixed django-stubs until tomorrow evening. Anyone else up for it? |
intgr
approved these changes
Jun 29, 2023
intgr
changed the title
Closed
|
This was fixed in django-stubs 4.2.3. |
|
Thanks! |
descope bot
added a commit
to descope/django-descope
that referenced
this pull request
Jul 20, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [django-stubs](https://togithub.com/typeddjango/django-stubs) ([changelog](https://togithub.com/typeddjango/django-stubs/releases)) | dev | patch | `4.2.2` -> `4.2.3` | --- ### Release Notes <details> <summary>typeddjango/django-stubs (django-stubs)</summary> ### [`v4.2.3`](https://togithub.com/typeddjango/django-stubs/releases/tag/4.2.3) [Compare Source](https://togithub.com/typeddjango/django-stubs/compare/4.2.2...4.2.3) This version fixes two regressions in previons `django-stubs` release and also a few other fixes and improvements. Special thanks to [@​GabDug](https://togithub.com/GabDug) for contributing regression fixes on a short order. This time there is no corresponding release of `django-stubs-ext`. ##### Stubs fixes - Fixed type error when subclassing `AppConfig` and assigning string to `default_auto_field` by [@​GabDug](https://togithub.com/GabDug) in [typeddjango/django-stubs#1596 - Fixed type error when subclassing `MiddlewareMixin.__call__()` and using `return self.get_response()` by [@​GabDug](https://togithub.com/GabDug) in [typeddjango/django-stubs#1595 - Allow `None` as `redirect_field_name` value for `@user_passes_test` and `@login_required` decorators by [@​JoeHitchen](https://togithub.com/JoeHitchen) in [typeddjango/django-stubs#1600 ##### Plugin fixes - Fixed long-standing issue with `Date(Time)Field` when using mypy setting `disallow_any_explicit` by [@​sobolevn](https://togithub.com/sobolevn) in [typeddjango/django-stubs#1599 ##### Stubs changes - Added `BigIntegerField.MAX_BIGINT` attribute by [@​asottile](https://togithub.com/asottile) in [typeddjango/django-stubs#1598 - Improved Jinja2 types and updated `pytest-mypy-plugins` by [@​sobolevn](https://togithub.com/sobolevn) in [typeddjango/django-stubs#1601 ##### CI/Testing - Run tests in multiple shards and all Python versions by [@​sobolevn](https://togithub.com/sobolevn) in [typeddjango/django-stubs#1603 ##### Housekeeping - Converted `_typeshed.Self` usages to `typing_extensions.Self` (PEP 673) by [@​intgr](https://togithub.com/intgr) in [typeddjango/django-stubs#1591 - Version 4.2.3 release (django-stubs only) by [@​intgr](https://togithub.com/intgr) in [typeddjango/django-stubs#1604 #### New Contributors - [@​JoeHitchen](https://togithub.com/JoeHitchen) made their first contribution in [typeddjango/django-stubs#1600 **Full Changelog**: typeddjango/django-stubs@4.2.2...4.2.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xLjExIiwidXBkYXRlZEluVmVyIjoiMzYuMS4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Loosen the typing for
AppConfig.default_auto_fieldto allowstror@property-likeRelated issues
Format is:
AppConfig.default_auto_field-- Incompatible types in assignment #1593