Fixed error when using async function based view in url path function

[ashm-tech]

Closes #1874

[sobolevn]

Sorry, I don't think that adding Coroutine[Any, Any, None] is correct.

In your case:

async def async_view(): 
    return HttpResponse(status=200)

it does not return None, it returns HttpResponse.

The correct fix is:

async def async_view() -> HttpResponse: 
    return HttpResponse(status=200)

[ashm-tech]

Yes, I agree with you!)

I changed None to HttpResponse

[sobolevn]

I still think that this change is not required, since Coroutine is covariant on the return type: https://github.com/python/typeshed/blob/16933b838eef7be92ee02f66b87aa1a7532cee63/stdlib/typing.pyi#L442

[ashm-tech]

I still think that this change is not required, since Coroutine is covariant on the return type: https://github.com/python/typeshed/blob/16933b838eef7be92ee02f66b87aa1a7532cee63/stdlib/typing.pyi#L442

We can add it, check how everything will work after if you don't need to delete it after

[intgr]

Assigned to @sobolevn. If you don't want to lead the review here, feel free to unassign yourself.

[flaeppe]

@ashm-tech do you want to continue the changes here? If yes, I'll make sure to help out with reviewing. I think what we need is a new @overload for path and re_path that covers for async responses.

Have a look at this #1874 (comment) to see what I mean.

We should also add a test for the new overload, anywhere in https://github.com/typeddjango/django-stubs/blob/6f7a19cf26257fb2da1c65c12a72807f9154dfe7/tests/typecheck/urls/test_conf.yml. I believe that will help trying out the changes.

[flaeppe]

Oh, sorry, just realised that this PR was superseded by #2085