Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.0: Remove extra_tests arg for DiscoverRunner.build_suite/run_tests #1978

Merged
merged 2 commits into from
Feb 25, 2024
Merged

5.0: Remove extra_tests arg for DiscoverRunner.build_suite/run_tests #1978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be27023
Remove extra_tests arg for DiscoverRunner.build_suite/run_tests
q0w Feb 25, 2024
aa54167
Fix test_labels
q0w Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions django-stubs/test/runner.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,7 @@ class DiscoverRunner:
@contextmanager
def load_with_patterns(self) -> Iterator[None]: ...
def load_tests_for_label(self, label: str, discover_kwargs: dict[str, str]) -> TestSuite: ...
def build_suite(
self, test_labels: Sequence[str] = ..., extra_tests: list[Any] | None = ..., **kwargs: Any
) -> TestSuite: ...
def build_suite(self, test_labels: Sequence[str] | None = ..., **kwargs: Any) -> TestSuite: ...
def setup_databases(self, **kwargs: Any) -> list[tuple[BaseDatabaseWrapper, str, bool]]: ...
def get_resultclass(self) -> type[TextTestResult] | None: ...
def get_test_runner_kwargs(self) -> dict[str, Any]: ...
Expand All @@ -157,7 +155,7 @@ class DiscoverRunner:
def suite_result(self, suite: TestSuite, result: TextTestResult, **kwargs: Any) -> int: ...
def _get_databases(self, suite: TestSuite) -> set[str]: ...
def get_databases(self, suite: TestSuite) -> set[str]: ...
def run_tests(self, test_labels: list[str], extra_tests: list[Any] | None = ..., **kwargs: Any) -> int: ...
def run_tests(self, test_labels: list[str], **kwargs: Any) -> int: ...

def is_discoverable(label: str) -> bool: ...
def reorder_suite(
Expand Down
1 change: 0 additions & 1 deletion scripts/stubtest/allowlist_todo.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1673,7 +1673,6 @@ django.templatetags.static.StaticNode.__init__
django.test.SimpleTestCase.assertFormError
django.test.SimpleTestCase.assertFormSetError
django.test.SimpleTestCase.assertTemplateNotUsed
django.test.runner.DiscoverRunner.build_suite
django.test.runner.DiscoverRunner.log
django.test.runner.DiscoverRunner.reorder_by
django.test.runner.DummyList
Expand Down
1 change: 0 additions & 1 deletion scripts/stubtest/allowlist_todo_django50.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,6 @@ django.test.client.AsyncClient.post
django.test.client.AsyncClient.put
django.test.client.AsyncClient.trace
django.test.runner.DiscoverRunner.__init__
django.test.runner.DiscoverRunner.run_tests
django.test.runner.RemoteTestResult.addDuration
django.utils.baseconv
django.utils.choices
Expand Down