Add GeoModelAdminMixin #1982
Open
Add GeoModelAdminMixin #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested changes
Feb 25, 2024
|
Should it be ignored?
|
|
I propose to ignore it for now with a comment (in |
|
@q0w you need |
|
Oh, ok, its reproducible |
sobolevn
reviewed
Feb 25, 2024
| @@ -394,3 +394,6 @@ django.urls.resolvers.URLPattern.lookup_str | |||
| django.urls.resolvers.URLResolver.url_patterns | |||
| django.urls.resolvers.URLResolver.urlconf_module | |||
| django.utils.connection.BaseConnectionHandler.settings | |||
|
|
|||
| # Potential mypy bug with metaclass | |||
| django.contrib.gis.admin.options.GeoModelAdminMixin.gis_widget | |||
There was a problem hiding this comment.
This also might be a bug with our plugin. Can you please try with and without ClassVar?
q0w
force-pushed
the
GeoModelAdminMixin
branch
from
e9c0ded
to
dcfa42e
Compare
This reverts commit dcfa42e.
q0w
commented
Feb 26, 2024
q0w
force-pushed
the
GeoModelAdminMixin
branch
from
7125a99
to
c78ef2c
Compare
|
Assigned to @sobolevn. If you don't want to lead the review here, feel free to unassign yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
https://github.com/django/django/blob/main/django/contrib/gis/admin/options.py#L6
Related issues