Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0: Update django.contrib.admin.widgets #2105

Merged
merged 4 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 12 additions & 3 deletions django-stubs/contrib/admin/widgets.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,18 @@ class FilteredSelectMultiple(forms.SelectMultiple):
choices: _Choices = ...,
) -> None: ...

class AdminDateWidget(forms.DateInput):
class BaseAdminDateWidget(forms.DateInput):
def __init__(self, attrs: _OptAttrs | None = ..., format: str | None = ...) -> None: ...

class AdminTimeWidget(forms.TimeInput):
class AdminDateWidget(BaseAdminDateWidget):
template_name: str

class BaseAdminTimeWidget(forms.TimeInput):
def __init__(self, attrs: _OptAttrs | None = ..., format: str | None = ...) -> None: ...

class AdminTimeWidget(BaseAdminTimeWidget):
template_name: str

class AdminSplitDateTime(forms.SplitDateTimeWidget):
template_name: str
def __init__(self, attrs: _OptAttrs | None = ...) -> None: ...
Expand Down Expand Up @@ -70,7 +76,6 @@ class ManyToManyRawIdWidget(ForeignKeyRawIdWidget):

class RelatedFieldWidgetWrapper(forms.Widget):
template_name: str
choices: ModelChoiceIterator
widget: forms.ChoiceWidget
rel: ManyToOneRel
can_add_related: bool
Expand All @@ -90,6 +95,10 @@ class RelatedFieldWidgetWrapper(forms.Widget):
) -> None: ...
@property
def is_hidden(self) -> bool: ...
@property
def choices(self) -> ModelChoiceIterator: ...
@choices.setter
def choices(self, value: ModelChoiceIterator) -> None: ...
def get_related_url(self, info: tuple[str, str], action: str, *args: Any) -> str: ...
def get_context(self, name: str, value: Any, attrs: _OptAttrs | None) -> dict[str, Any]: ...
def value_from_datadict(self, data: Mapping[str, Any], files: Mapping[str, Iterable[File]], name: str) -> Any: ...
Expand Down
4 changes: 2 additions & 2 deletions scripts/stubtest/allowlist_todo.txt
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@ django.contrib.admin.views.autocomplete.AutocompleteJsonView.process_request
django.contrib.admin.views.autocomplete.AutocompleteJsonView.serialize_result
django.contrib.admin.views.main.ChangeList.search_form_class
django.contrib.admin.widgets.AutocompleteMixin.media
django.contrib.admin.widgets.BaseAdminDateWidget
django.contrib.admin.widgets.BaseAdminTimeWidget
django.contrib.admin.widgets.FilteredSelectMultiple.Media
django.contrib.admin.widgets.get_select2_language
django.contrib.admin.widgets.BaseAdminTimeWidget.Media
django.contrib.admin.widgets.BaseAdminDateWidget.Media
django.contrib.admindocs.utils.non_capturing_group_matcher
django.contrib.admindocs.utils.remove_non_capturing_groups
django.contrib.admindocs.utils.replace_metacharacters
Expand Down