Fix signature of RemoteUserBackend.configure_user #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function signature has changed from 2.1 on 2.2 but django-stubs did not follow that. https://github.com/django/django/blob/2.1.15/django/contrib/auth/backends.py#L163 https://github.com/django/django/blob/2.2/django/contrib/auth/backends.py#L177
sobolevn
requested changes
Nov 19, 2020
| @@ -35,6 +35,6 @@ class AllowAllUsersModelBackend(ModelBackend): ... | |||
| class RemoteUserBackend(ModelBackend): | |||
| create_unknown_user: bool = ... | |||
| def clean_username(self, username: str) -> str: ... | |||
| def configure_user(self, user: User) -> User: ... | |||
| def configure_user(self, request: Any, user: User) -> User: ... | |||
There was a problem hiding this comment.
I guess it should be request: HttpRequest
There was a problem hiding this comment.
The function is used in authenticate() method and the request type, which is directly passed, in that function is Any
https://github.com/django/django/blob/stable/2.2.x/django/contrib/auth/backends.py#L150-L160
https://github.com/typeddjango/django-stubs/blob/master/django-stubs/contrib/auth/backends.pyi#L14
Shall I
- Let it go?
- Fix type definition of
authenticate()as well?
I'm not sure if request in authenticate() is HttpRequest or can be others.
There was a problem hiding this comment.
Any ideas what else can it be?
There was a problem hiding this comment.
No idea. I just said I'm not sure while I didn't wrote the definition of authenticate().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
The function signature of
django.contrib.auth.backends.RemoteUserBackend.configure_userhas changed from 2.1 on 2.2 but django-stubs did not follow that.stable/2.1.x
https://github.com/django/django/blob/stable/2.1.x/django/contrib/auth/backends.py#L163
stable/2.2.x ~ stable/3.1.x
https://github.com/django/django/blob/stable/2.2.x/django/contrib/auth/backends.py#L177
https://github.com/django/django/blob/stable/3.0.x/django/contrib/auth/backends.py#L236
https://github.com/django/django/blob/stable/3.1.x/django/contrib/auth/backends.py#L222
Related issues
I couldn't found any.