Fix type of prefix arg in staticfiles_urlpatterns #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a *type* of None for the prefix keyword argument is not going to typecheck very well, so it might be a typo here because the default value (rather than the type) is None. Signed-off-by: aszlig <aszlig@nix.build>
|
@mkurnikov: Hm, is CI currently broken? It can't find |
voidus
pushed a commit
to voidus/django-stubs
that referenced
this pull request
Apr 23, 2024
This finishes the work done in typeddjango#126. Commits are cherry-picked to give the original author credit. I also removed psycopg2 tests as they are typeshed's problem now. Fixes typeddjango#74 Closes typeddjango#126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a type of
Nonefor the prefix keyword argument is not going to typecheck very well, so it might be a typo here because the default value (rather than the type) isNone.