Create regression test for related managers 2022 #967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
reviewed
May 25, 2022
|
|
||
| def process_user(user: User): | ||
| reveal_type(user.bookingowner_set) # N: Revealed type is 'django.db.models.manager.RelatedManager[myapp.models.Booking]' | ||
| reveal_type(user.booking_set) # N: Revealed type is 'django.db.models.manager.RelatedManager[myapp.models.Booking]' |
There was a problem hiding this comment.
We could consider using typing_extensions.assert_type() instead of reveal_type(), which is less verbose.
But would need to ensure that testing dependencies are typing-extensions>=4.2.0 and mypy>=0.950 then.
There was a problem hiding this comment.
I think that it won't work with our pytest-mypy-plugin lib 🤔
sobolevn
reviewed
May 25, 2022
| ordering = ['-created_at'] | ||
|
|
||
| def process_user(user: User): | ||
| reveal_type(user.bookingowner_set) # N: Revealed type is 'django.db.models.manager.RelatedManager[myapp.models.Booking]' |
There was a problem hiding this comment.
Suggested change
| reveal_type(user.bookingowner_set) # N: Revealed type is 'django.db.models.manager.RelatedManager[myapp.models.Booking]' | |
| reveal_type(user.bookingowner_set) # N: Revealed type is "django.db.models.manager.RelatedManager[myapp.models.Booking]" |
|
|
||
| def process_user(user: User): | ||
| reveal_type(user.bookingowner_set) # N: Revealed type is 'django.db.models.manager.RelatedManager[myapp.models.Booking]' | ||
| reveal_type(user.booking_set) # N: Revealed type is 'django.db.models.manager.RelatedManager[myapp.models.Booking]' |
There was a problem hiding this comment.
Suggested change
| reveal_type(user.booking_set) # N: Revealed type is 'django.db.models.manager.RelatedManager[myapp.models.Booking]' | |
| reveal_type(user.booking_set) # N: Revealed type is "django.db.models.manager.RelatedManager[myapp.models.Booking]" |
|
Closed in favor of #993. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RelatedManagers do not get set up for me anymore with the latest plugin rewrites.
I took another stab at making a test case.
#902 (comment)