Fix BaseModelFormSet.save_m2m: accept self
#970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it would result in the following when calling it: > Attribute function "save_m2m" with type "Callable[[], None]" does not accept self argument [misc]
sobolevn
reviewed
May 25, 2022
django-stubs/forms/models.pyi
Outdated
| @@ -150,7 +150,7 @@ class BaseModelFormSet(Generic[_M, _ModelFormT], BaseFormSet[_ModelFormT]): | |||
| def save_existing(self, form: _ModelFormT, instance: _M, commit: bool = ...) -> _M: ... | |||
| def delete_existing(self, obj: _M, commit: bool = ...) -> None: ... | |||
| saved_forms: List[_ModelFormT] = ... | |||
| save_m2m: Callable[[], None] = ... | |||
| save_m2m: Callable[[self], None] = ... | |||
There was a problem hiding this comment.
Myabe we should re-write it as def save_m2m?
There was a problem hiding this comment.
ok, done.
Note that it is a method that will only be there when commit=False is used before, but I think that cannot be reflected really.
sobolevn
approved these changes
May 27, 2022
| @@ -150,7 +150,7 @@ class BaseModelFormSet(Generic[_M, _ModelFormT], BaseFormSet[_ModelFormT]): | |||
| def save_existing(self, form: _ModelFormT, instance: _M, commit: bool = ...) -> _M: ... | |||
| def delete_existing(self, obj: _M, commit: bool = ...) -> None: ... | |||
| saved_forms: List[_ModelFormT] = ... | |||
| save_m2m: Callable[[self], None] = ... | |||
| def save_m2m(self) -> None: ... | |||
There was a problem hiding this comment.
Context: I think that confusion came from these lines: https://github.com/django/django/blob/8c0886b068ba4e224dd78104b93c9638b860b398/django/forms/models.py#L781-L785
But, this is indeed a instance-level method. So, self is there.
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it would result in the following when calling it:
Originally added in https://github.com/typeddjango/django-stubs/pull/909/files#diff-3201a55e0a4a5182b8e53740898a55b982ca9c47806c4d4d7be224c1c68bcb39R152
/cc @sterliakov (Thanks for this great update btw!)