Update to mypy 0.991 for compatible-mypy & CI #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
commented
Nov 8, 2022
| show_traceback = True | ||
| allow_redefinition = True | ||
| incremental = True | ||
| show_error_codes = False | ||
| disable_error_code = empty-body |
There was a problem hiding this comment.
warn_no_return is no longer necessary now that we disable empty-body.
intgr
commented
Nov 8, 2022
|
|
||
| class BasePermission(metaclass=BasePermissionMetaclass): # type: ignore[misc] | ||
| def has_permission(self, request: Request, view: APIView) -> bool: ... | ||
| def has_object_permission(self, request: Request, view: APIView, obj: Any) -> bool: ... |
There was a problem hiding this comment.
If I kept _SupportsHasPermission here, it causes "Metaclass conflict" errors.
I don't understand metaclasses well enough to say whether that's a bug in mypy or a genuine issue.
But duplicating these method signatures here fixes it.
|
typecheck-tests is not running correctly any more. All ignores show up in "UNUSED IGNORES" now. EDIT: May be a mypy bug, reported upstream: python/mypy#14042 |
intgr
force-pushed
the
update-to-mypy-0.990
branch
from
558a62c
to
21d86ad
Compare
intgr
commented
Nov 12, 2022
intgr
force-pushed
the
update-to-mypy-0.990
branch
2 times, most recently
from
f2a0737
to
832a704
Compare
intgr
changed the title
intgr
force-pushed
the
update-to-mypy-0.990
branch
from
832a704
to
e673bac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.