Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.8.0 release #293

Merged
merged 1 commit into from Nov 18, 2022
Merged

Version 1.8.0 release #293

merged 1 commit into from Nov 18, 2022

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Nov 16, 2022

@sobolevn Let's make a release, there's a significant number of things in master, including full compatibility with django-stubs 1.13.0, Python 3.10 and mypy 0.991.

I have created draft release notes at https://github.com/typeddjango/djangorestframework-stubs/releases

This PR also tweaks a few places in documentation:

  • Updated Python compatibility in setup.py and README.
  • Removed DRF version from README -- it has been out of date for a while.
  • Added link to typeshed coding conventions that's now enforced by flake8-pyi

@intgr
Copy link
Contributor Author

intgr commented Nov 16, 2022

Just as I was creating this PR, a commit in django-rest-framework broke our typecheck. Fixed in #294.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should also decide about the versioning policy.
Probably, it should be the same as django-stubs will have.

Also:

* Updated Python compatibility in setup.py and README.
* Removed DRF version from README -- it has been out of date for a while.
* Added link to typeshed coding conventions that's now enforced by `flake8-pyi`
@intgr
Copy link
Contributor Author

intgr commented Nov 18, 2022

Let's do this.

@intgr intgr merged commit 2584ad3 into typeddjango:master Nov 18, 2022
@intgr
Copy link
Contributor Author

intgr commented Nov 18, 2022

@sobolevn Whaat, why was the release workflow deleted in 06f84b2? You should at least explain reasons in the commit message.

I had no idea. I was under the impression that it's as easy as pushing a tag. I am unable to make a release myself then.

@sobolevn
Copy link
Member

@intgr it was broken - after PyPI required 2FA. And since I was the only one releasing stuff, it was easier to do it manually. I will release it right now. Can you please send me PyPI account via email?

@sobolevn
Copy link
Member

@intgr
Copy link
Contributor Author

intgr commented Nov 18, 2022

OK, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants