Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Remove unused typecheck ignores #295

Merged
merged 2 commits into from Nov 16, 2022
Merged

CI: Remove unused typecheck ignores #295

merged 2 commits into from Nov 16, 2022

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Nov 16, 2022 •
edited

typecheck_tests.py contains lots of ignores that are now obsolete.

Instead of using IGNORED_MODULES for some files, now added the remaining issues in these files to IGNORED_ERRORS

@intgr intgr force-pushed the remove-unused-typecheck-ignores branch from f402ff3 to 87dea03 Compare November 16, 2022 16:13
@intgr intgr marked this pull request as ready for review November 16, 2022 16:13
sobolevn
sobolevn approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the cleanup!

@intgr intgr merged commit d3067dd into master Nov 16, 2022
@intgr intgr deleted the remove-unused-typecheck-ignores branch November 16, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@intgr @sobolevn