Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Always install django-stubs from git master #417

Merged
merged 2 commits into from May 13, 2023

Conversation

intgr
Copy link
Contributor

@intgr intgr commented May 13, 2023

It's not uncommon to need to coordinate changes between django-stubs and djangorestframework-stubs projects. E.g. I need to make some changes in django-stubs first and then also make a similar change here that builds on django-stubs. Happens particularly often with mypy updates like #416.

So I propose making django-stubs permanently a git dependency in CI and development requirements.txt

@intgr intgr changed the title CI: Always use django-stubs from git master CI: Always install django-stubs from git master May 13, 2023
@intgr intgr force-pushed the ci-use-django-stubs-from-git-master branch from 329bae1 to 3b813c4 Compare May 13, 2023 09:28
@intgr
Copy link
Contributor Author

intgr commented May 13, 2023

A bit offtopic but related: Most of the problems with using older django-stubs are failures in our CI that do not occur in actual user projects (in my experience).

But there's a risk of creating a dependency on other changes already merged in django-stubs and we don't test against multiple django-stubs versions. So I'm thinking going forward we should consider bumping DRF-stubs dependency on django-stubs with every DRF-stubs release.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, seems reasonable. We already synchronize releases, so it can decrease the amount of problems during development with no real risks.

@intgr intgr merged commit 900626b into typeddjango:master May 13, 2023
13 checks passed
@intgr intgr mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants