Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pkg_resources with packaging for Python 3.12 compatibility. #112

Merged
merged 3 commits into from
May 4, 2023
Merged

Replace pkg_resources with packaging for Python 3.12 compatibility. #112

merged 3 commits into from
May 4, 2023

Conversation

brunns
Copy link
Contributor

@brunns brunns commented May 4, 2023

Fix for #111

@brunns
Copy link
Contributor Author

brunns commented May 4, 2023

Will need to be rebased over #113 so the tests pass.

@sobolevn sobolevn closed this May 4, 2023
@sobolevn sobolevn reopened this May 4, 2023
sobolevn
sobolevn reviewed May 4, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add 3.11 to the test?

@brunns brunns force-pushed the replace-pkg_resources-with-packaging branch from d55b54b to e7b8e26 Compare May 4, 2023 09:03
@brunns
Copy link
Contributor Author

brunns commented May 4, 2023

Looks OK now.

sobolevn
sobolevn approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit 27f6edd into typeddjango:master May 4, 2023
16 checks passed
@brunns brunns deleted the replace-pkg_resources-with-packaging branch May 4, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brunns @sobolevn