Move isort config to pyproject.toml and add black profile #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
pyproject.toml
and dropssetup.cfg
.Reasons
Currently isort's
--profile=black
is used only in CI, which means that you have to remember do the same locally (which I personally forgot). This can lead to situations whereisort
doesn't detect any problems locally (if profile is accidentally committed) but fails in CI.Additionally, isort recommends
pyproject.toml
for storing configuration andsetup.cfg
is not used for anything else (other dev tool configs could be migrated as well).