Use ApplyPatches and NewPatches messages to send and apply patches #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implementation of #40 |
|
Gonna close this after our discussion today - we're going to try a different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Waiting on Changes from #48 to be merged in.
This is also not 100% robust and is still a bit fragile. I'm thinking about changing the algorithm up a little bit, but don't want to throw away all this work.
There are a lot of edge cases that need to be caught with this approach. This was a PITA to test and I still don't think it works for some cases (e.g. deleting across columns).
Feel free to look at it but don't waste time fully reviewing it since I might change it to something easier (Atom's API should allow us to implement this with greater ease).