Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions >1.6.8 call fontinactive for fonts that are already in the page #284

Closed
grabks opened this issue Oct 30, 2015 · 1 comment
Closed

Comments

@grabks
Copy link

grabks commented Oct 30, 2015

Versions of WebFontLoader 1.6.8 and forward appear to have an issue when loading a font that is already available. This jsfiddle is a great example.

The jsfiddle loads some variants of the Roboto font itself via a <link> tag, includes version 1.6.10 of the WebFontLoader (also tried with 1.6.8 and 1.6.7), and attempts to load the Roboto font via WebFont.load. As you can see from the console messages, the version in that jsfiddle will report the Roboto font as inactive. When I tested version 1.6.7, it did indeed call the correct callback (fontactive).

@omo
Copy link
Contributor

omo commented Oct 30, 2015

Probably a regression from my change. Let me see.

bramstein added a commit that referenced this issue Nov 17, 2015
Fix #284: Handle duplication on NativeFontWatchRunner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants