Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patched microaeson-0.1.0.0 #149

Closed
wants to merge 1 commit into from
Closed

Conversation

jneira
Copy link
Collaborator

@jneira jneira commented Jul 29, 2019

To make HSYaml-2.0 work

@jneira jneira requested a review from rahulmutt July 29, 2019 11:08
@rahulmutt
Copy link
Member

As discussed on Gitter, can you see if you can add a build-tool-depends to cut down this patch?

@jneira
Copy link
Collaborator Author

jneira commented Jul 31, 2019

Mmm, i've tested it removing the global alex executable and with and without build-tools and build-tool-depends, both with and without deps bounds and it always asks for alex:

etlas.exe: The program 'alex' is required but it could not be found.

should it install the custom version for eta?

@jneira
Copy link
Collaborator Author

jneira commented Jul 31, 2019

Mmm i start to wonder if it is a windows specific bug: i have alex in the store dir but in its bin dir there is the alex.cmd generated script for windows. When i try to run it with etlas it doesnt find the executable:

>etlas run alex -- --version
Up to date
etlas: Unknown executable alex in package
alex-3.2.4-0a3edf06fccf11618d5bdac1ec38e9eeffa31933

I guess in linux it is able to run the wrapper script over the java call but it can't in windows..

@jneira
Copy link
Collaborator Author

jneira commented Jul 31, 2019

Uh i've wiped out the alex folder in the store and after rebuild the package alex, etlas is able to execute it, weird cause the new folder is apparently equal to removed one

But building the package throws the same error about missing alex, so maybe it cant find the .cmd of a required program?:

?callStack, called at .\Distribution\Compat\Stack.hs:45:13 in etlas_1lPwCyzvAfM6
mN1zk19Qet:Distribution.Compat.Stack
  callStack, called at .\Distribution\Simple\Utils.hs:592:44 in etlas_1lPwCyzvAf
M6mN1zk19Qet:Distribution.Simple.Utils
  withCallStackPrefix, called at .\Distribution\Simple\Utils.hs:629:7 in etlas_1
lPwCyzvAfM6mN1zk19Qet:Distribution.Simple.Utils
  withMetadata, called at .\Distribution\Simple\Utils.hs:354:15 in etlas_1lPwCyz
vAfM6mN1zk19Qet:Distribution.Simple.Utils
  die', called at .\Distribution\Simple\Program\Db.hs:423:28 in etlas_1lPwCyzvAf
M6mN1zk19Qet:Distribution.Simple.Program.Db
  requireProgram, called at .\Distribution\Simple\Configure.hs:1471:27 in etlas_
1lPwCyzvAfM6mN1zk19Qet:Distribution.Simple.Configure
  configureRequiredProgram, called at .\Distribution\Simple\Configure.hs:1415:10
 in etlas_1lPwCyzvAfM6mN1zk19Qet:Distribution.Simple.Configure
  configureRequiredPrograms, called at .\Distribution\Simple\Configure.hs:594:11
 in etlas_1lPwCyzvAfM6mN1zk19Qet:Distribution.Simple.Configure
  configure, called at .\Distribution\Simple.hs:593:20 in etlas_1lPwCyzvAfM6mN1z
k19Qet:Distribution.Simple
  confHook, called at .\Distribution\Simple\UserHooks.hs:67:5 in etlas_1lPwCyzvA
fM6mN1zk19Qet:Distribution.Simple.UserHooks
  confHook, called at .\Distribution\Simple.hs:224:24 in etlas_1lPwCyzvAfM6mN1zk
19Qet:Distribution.Simple
  configureAction, called at .\Distribution\Simple.hs:184:19 in etlas_1lPwCyzvAf
M6mN1zk19Qet:Distribution.Simple

etlas.exe: The program 'alex' is required but it could not be found.

@jneira
Copy link
Collaborator Author

jneira commented Jul 31, 2019

If i set in etlas global config the exact path of alex .cmd script it can execute it when building the package:

program-locations
  alex-location: \path\to\etlas\store\alex-3.2.4-hash\bin\alex.cmd

so i think programFindLocation or findProgramOnSearchPath are not able to find the .cmd script in windows.
As there is a workaround and i think in linux/macos it will work i am gonna change the patch to restore the .x file

@jneira
Copy link
Collaborator Author

jneira commented Jul 31, 2019

Another definitive test: if i remove the hardcoded location in etlas config and put the alex.exe in \path\to\etlas\store\alex-3.2.4-hash\bin etlas execute them building the package.

And if we have another alex in global PATH etlas picks up it.

@jneira
Copy link
Collaborator Author

jneira commented Jul 31, 2019

Closing cause the package can be built patching aeson-1.3.1.1 to build tests

@jneira jneira closed this Jul 31, 2019
@jneira jneira deleted the microaeson branch July 31, 2019 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants