Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dhall builtin cache to speed up etlas.dhall use #88

Merged
merged 11 commits into from
Jan 30, 2019
Merged

Use dhall builtin cache to speed up etlas.dhall use #88

merged 11 commits into from
Jan 30, 2019

Conversation

jneira
Copy link
Collaborator

@jneira jneira commented Jan 29, 2019

  • etlas save an additional file named with canonical path to dhall.etlas hashed and put the dhall cache key in
    • it save it in the <etlas.dhall dir>/dist/cache
  • in subsequent config uses it reads that file, retrieves de dhall cache key and uses it

@jneira jneira requested a review from rahulmutt January 29, 2019 12:01
@jneira jneira mentioned this pull request Jan 29, 2019
Open
5 tasks
rahulmutt
rahulmutt approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@rahulmutt rahulmutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful work @jneira! One step closer to making dhall default :)

@rahulmutt rahulmutt merged commit 6dea31a into typelead:master Jan 30, 2019
@jneira jneira deleted the dhall-cache branch January 31, 2019 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulmutt rahulmutt rahulmutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jneira @rahulmutt