dotty-cps-async 0.9.20 #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djspiewak
approved these changes
Mar 13, 2024
|
Thank you for tackling this! I've been putting it off for quite a while |
lhns
force-pushed
the
feature/dotty-cps-async-0.9.20
branch
from
00ae8c9
to
12fd89d
Compare
|
I am still a bit new to the new scala 3 implicit resolution rules but they seem to work pretty well without needing the LowPriorityImplicits pattern. |
djspiewak
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I ran into a few edge cases with the macros of dotty-cps-async 0.9.16 which seem to be fixed in the newer versions so I updated it to 0.9.20. I also split up the type classes to make this work with Monads, Try, etc. (Fixes #75 ) This PR will probably break bin compat because I removed the auto coloring stuff which is not available anymore in the newer versions of dotty-cps-async.