Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct IO#racePair docs #2733

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Correct IO#racePair docs #2733

merged 1 commit into from
Jan 10, 2022

Conversation

TimWSpence
Copy link
Member

No description provided.

@rtjfarrimond rtjfarrimond mentioned this pull request Jan 7, 2022
Closed
armanbilge
armanbilge previously approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@armanbilge
Copy link
Member

Oh, actually can this be re-targeted at 3.3.x?

@TimWSpence TimWSpence changed the base branch from series/3.x to series/3.3.x January 7, 2022 17:31
@TimWSpence TimWSpence dismissed armanbilge’s stale review January 7, 2022 17:31

The base branch was changed.

@TimWSpence TimWSpence changed the base branch from series/3.3.x to series/3.0.x January 7, 2022 17:32
@TimWSpence TimWSpence changed the base branch from series/3.0.x to series/3.x January 7, 2022 17:32
@TimWSpence
Copy link
Member Author

Oh, actually can this be re-targeted at 3.3.x?

I tried and failed horribly 😂 What is the preferred approach to this? Change the base in GH and then rebase my branch onto 3.3.x?

@armanbilge
Copy link
Member

Yeah, unfortunately can't be done just from GH :)

@TimWSpence TimWSpence changed the base branch from series/3.x to series/3.3.x January 7, 2022 17:42
@TimWSpence
Copy link
Member Author

Yeah, unfortunately can't be done just from GH :)

Yeah I suspected not! Done now (I think 😂 )

djspiewak
djspiewak previously requested changes Jan 8, 2022
View reviewed changes
Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. It does need a run of sbt prePR though :-)

@djspiewak
Copy link
Member

So correction: docs stuff should ideally be targeted at series/3.x. Sorry to keep bouncing it around a bit :-)

@armanbilge
Copy link
Member

armanbilge commented Jan 9, 2022 •
edited
Loading

Wait, why is that? Are we publishing the docs from 3.x?

Edit: If we are, that doesn't make sense because it means are publishing docs for new APIs e.g. allocatedCase that have not yet been published. Furthermore, this fix should benefit users who read their scaladocs in their IDE. In both cases, I would think we want it merged into 3.3.x.

@armanbilge armanbilge closed this Jan 10, 2022
@armanbilge armanbilge reopened this Jan 10, 2022
@armanbilge armanbilge merged commit e284f2c into typelevel:series/3.3.x Jan 10, 2022
@TimWSpence TimWSpence deleted the doc-fix branch January 10, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

@djspiewak djspiewak djspiewak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TimWSpence @armanbilge @djspiewak