Add Recipe presenting real world use case #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djspiewak
requested changes
Feb 22, 2023
docs/recipes.md
Outdated
|
|
||
| ```scala mdoc:silent | ||
| def update(input: Int): IO[Int] = | ||
| IO.defer(input + 1 ) |
There was a problem hiding this comment.
Suggested change
| IO.defer(input + 1 ) | |
| IO(input + 1 ) |
:-) I think you meant delay, but apply is even more concise.
docs/recipes.md
Outdated
| ```scala mdoc:silent | ||
| class Server(atomicCell: AtomicCell[IO, Int]) { | ||
| def update(input: Int): IO[Int] = | ||
| IO.defer(input + 1 ) |
There was a problem hiding this comment.
Suggested change
| IO.defer(input + 1 ) | |
| IO(input + 1 ) |
docs/recipes.md
Outdated
| So, let's assume that we want to implement very simple rate limiting proxy, that will only allow some specific number of requests and then return failure if this limit is surpassed. | ||
|
|
||
| The code could look like below: | ||
| ```scala mdoc:silet |
There was a problem hiding this comment.
Suggested change
| ```scala mdoc:silet | |
| ```scala mdoc:silent |
docs/recipes.md
Outdated
| class RateLimiterProxy(limit: Int, cell: AtomicCell[IO, Int], service: Service){ | ||
| def limit[A](request: IO[Request]): IO[Response] = { | ||
| cell.evalModify{ requests => | ||
| if(requests >= limit) |
There was a problem hiding this comment.
Suggested change
| if(requests >= limit) | |
| if (requests >= limit) |
docs/recipes.md
Outdated
|
|
||
| class RateLimiterProxy(limit: Int, cell: AtomicCell[IO, Int], service: Service){ | ||
| def limit[A](request: IO[Request]): IO[Response] = { | ||
| cell.evalModify{ requests => |
There was a problem hiding this comment.
Suggested change
| cell.evalModify{ requests => | |
| cell evalModify { requests => |
Wosin
force-pushed
the
atomic-cell-recipe
branch
from
a272a9a
to
f04fe3d
Compare
|
Hey, I've actually found simpler example, let me know if that works, I think RateLimiter was a little farfetched. |
iRevive
reviewed
Feb 27, 2023
iRevive
reviewed
Feb 27, 2023
iRevive
reviewed
Feb 27, 2023
iRevive
reviewed
Feb 27, 2023
Co-authored-by: Maksym Ochenashko <maxochenashko@gmail.com>
Wosin
force-pushed
the
atomic-cell-recipe
branch
from
fc1031c
to
a8ccac8
Compare
Wosin
force-pushed
the
atomic-cell-recipe
branch
from
a8ccac8
to
c5ea23f
Compare
djspiewak
requested changes
Mar 7, 2023
Co-authored-by: Daniel Spiewak <djspiewak@gmail.com>
iRevive
reviewed
Mar 8, 2023
Co-authored-by: Maksym Ochenashko <maxochenashko@gmail.com>
iRevive
reviewed
Mar 13, 2023
djspiewak
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking about something that presents a concept in a simple manner but also captures the essence of update based on the effectful result, but not too sure if this example is the best.