Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually restore IODeferred specialization #3489

Merged
merged 2 commits into from
Mar 11, 2023
Merged

Actually restore IODeferred specialization #3489

merged 2 commits into from
Mar 11, 2023

Conversation

armanbilge
Copy link
Member

No description provided.

@armanbilge
Copy link
Member Author

Well this is very embarrassing 😳 I don't think we ever actually brought it back in #3403. That also probably means the benchmarks I offered there are completely moot 🤔

@armanbilge armanbilge changed the title Re-enable specialized deferred test Actually restore IODeferred specialization Mar 10, 2023
@armanbilge armanbilge marked this pull request as draft March 10, 2023 23:07
@armanbilge
Copy link
Member Author

Oh gosh! That probably explains why this PR didn't improve benchmarks either 😭

@armanbilge armanbilge marked this pull request as ready for review March 10, 2023 23:30
@armanbilge
Copy link
Member Author

This PR

Benchmark                   (count)   Mode  Cnt     Score    Error  Units
DeferredBenchmark.cancel         10  thrpt   20    41.553 ±  0.708  ops/s
DeferredBenchmark.cancel        100  thrpt   20     4.882 ±  0.291  ops/s
DeferredBenchmark.cancel       1000  thrpt   20     0.413 ±  0.014  ops/s
DeferredBenchmark.complete       10  thrpt   20    31.238 ±  3.586  ops/s
DeferredBenchmark.complete      100  thrpt   20     8.244 ±  1.767  ops/s
DeferredBenchmark.complete     1000  thrpt   20     0.993 ±  0.364  ops/s
DeferredBenchmark.get            10  thrpt   20  1650.125 ± 54.401  ops/s
DeferredBenchmark.get           100  thrpt   20   256.456 ±  2.135  ops/s
DeferredBenchmark.get          1000  thrpt   20    26.779 ±  0.231  ops/s

series/3.4.x

Benchmark                   (count)   Mode  Cnt     Score    Error  Units
DeferredBenchmark.cancel         10  thrpt   20    40.660 ±  0.732  ops/s
DeferredBenchmark.cancel        100  thrpt   20     4.272 ±  0.124  ops/s
DeferredBenchmark.cancel       1000  thrpt   20     0.355 ±  0.017  ops/s
DeferredBenchmark.complete       10  thrpt   20    30.792 ±  3.347  ops/s
DeferredBenchmark.complete      100  thrpt   20     8.399 ±  1.543  ops/s
DeferredBenchmark.complete     1000  thrpt   20     1.186 ±  0.261  ops/s
DeferredBenchmark.get            10  thrpt   20  1021.676 ± 12.172  ops/s
DeferredBenchmark.get           100  thrpt   20   165.704 ±  4.359  ops/s
DeferredBenchmark.get          1000  thrpt   20    18.971 ±  1.378  ops/s

djspiewak
djspiewak approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol that's an embarrassing miss. I completely failed to catch it during the review, sorry.

@djspiewak djspiewak merged commit b35eda1 into series/3.4.x Mar 11, 2023
@armanbilge armanbilge deleted the fix/specialized-deferred-test branch April 16, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djspiewak djspiewak djspiewak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@armanbilge @djspiewak