Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mutex cancelled acquire even more #3555

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Fix mutex cancelled acquire even more #3555

merged 7 commits into from
Apr 25, 2023

Conversation

durban
Copy link
Contributor

@durban durban commented Apr 24, 2023

Hopefully should fix #3554. Same trick as for Queue.

@durban durban mentioned this pull request Apr 24, 2023
Closed
@djspiewak
Copy link
Member

Btw should probably use .timeoutTo inside of the test where you're expecting not-a-hang, just to sidestep the Specs issue

@djspiewak
Copy link
Member

Btw, I've been seeing a lot of MutexSpec failures on #3557. I'm thinking we merge this PR and then we can work on trying to bring that one in. Unfortunately, I suspect we've had a lot more CI failures than we thought masked by this Specs2 bug.

@armanbilge
Copy link
Member

Once this lands if we publish a snapshot I can test skunk again.

@djspiewak
Copy link
Member

@durban Is this ready to go? It's still marked as draft so I was holding off on doing things with it.

@durban durban marked this pull request as ready for review April 25, 2023 19:03
@durban
Copy link
Contributor Author

durban commented Apr 25, 2023

@djspiewak Yeah, sorry, I've kept it as draft because I was expecting CI failures (I had to figure out an appropriate timeout length). Should be good now.

In theory the longer timeout here could help with the MutexSpec failures in #3557 (I suspect the existing "not deadlock when highly contended" test was secretly already timing out in CI).

@BalmungSan BalmungSan mentioned this pull request Apr 25, 2023
Merged
@djspiewak djspiewak merged commit 3f61234 into typelevel:series/3.x Apr 25, 2023
35 checks passed
@armanbilge armanbilge mentioned this pull request Apr 26, 2023
Open
@armanbilge
Copy link
Member

Nice, 3f61234 appears to have fixed Skunk. Thank you!! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djspiewak djspiewak djspiewak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In theory, waiters can be lost in Mutex
3 participants
@durban @djspiewak @armanbilge