Fix queueMicrotask polyfill
#3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported-by: jilen <jilen.zhang@gmail.com>
durban
approved these changes
Jun 15, 2023
| @@ -46,7 +46,7 @@ private[effect] final class BatchingMacrotaskExecutor( | |||
| if (js.typeOf(js.Dynamic.global.queueMicrotask) == "function") | |||
| js.Dynamic.global.queueMicrotask.asInstanceOf[js.Function1[js.Function0[Any], Any]] | |||
| else { | |||
| val resolved = js.Dynamic.global.Promise.resolved(()) | |||
| val resolved = js.Dynamic.global.Promise.resolve(()) | |||
There was a problem hiding this comment.
Nitpicking: val resolved could be val resolve instead.
There was a problem hiding this comment.
I was going for verb vs adjective: "I will resolve the promise, then I will have a resolved promise".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dang dynamic languages! Don't think we can test this without a really old Node.js or a crappy browser. Maybe if we could rig up a raw V8, but meh.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/resolve
h/t @jilen