Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Dispatcher#unsafeRunAndForget #3878

Merged
merged 4 commits into from Nov 23, 2023
Merged

Optimize Dispatcher#unsafeRunAndForget #3878

merged 4 commits into from Nov 23, 2023

Conversation

kamilkloch
Copy link
Contributor

@kamilkloch kamilkloch commented Oct 18, 2023 •
edited

Removed default Dispatcher#unsafeRunAndForget as it was never used.
Cannot be removed in 3.5.x. due to bincompat.

Optimized the remaining implementation of unsafeRunAndForget so it does not go through unsafeRunAsync and extra allocation.

dispatcher-flame-graph

@kamilkloch kamilkloch changed the base branch from series/3.x to series/3.5.x October 18, 2023 11:07
@djspiewak djspiewak merged commit f6a6f18 into typelevel:series/3.5.x Nov 23, 2023
28 of 32 checks passed
@armanbilge armanbilge changed the title Follow-up on #3822 Optimize Dispatcher#unsafeRunAndForget Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djspiewak djspiewak djspiewak approved these changes

Assignees
No one assigned
Labels
🍄 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamilkloch @djspiewak @armanbilge