Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear up Resource docs #516

Merged
merged 2 commits into from Apr 30, 2019
Merged

Clear up Resource docs #516

merged 2 commits into from Apr 30, 2019

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented Apr 26, 2019

Closes #336

@codecov-io
Copy link

Codecov Report

Merging #516 into master will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
+ Coverage    89.6%   89.75%   +0.14%     
==========================================
  Files          70       70              
  Lines        2050     2050              
  Branches      196      196              
==========================================
+ Hits         1837     1840       +3     
+ Misses        213      210       -3

rossabaker
rossabaker approved these changes Apr 27, 2019
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One trivial edit suggestion.

site/src/main/tut/datatypes/resource.md Outdated Show resolved Hide resolved
site/src/main/tut/datatypes/resource.md

```
//latch to make sure we cancel the `use` after it's actually started
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing clever we can do to make this a tut shed, because the tut would never terminate, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so :/

@rossabaker @kubukoz
Update site/src/main/tut/datatypes/resource.md
7fbcc20 
Co-Authored-By: kubukoz <kubukoz@gmail.com>
@djspiewak
Copy link
Member

Merge with master?

@rossabaker
Copy link
Member

If we decide to do a 1.3 in addition to a 2.0 milestone, this should target series/1.x.

@rossabaker rossabaker changed the base branch from master to series/1.x April 30, 2019 03:20
@djspiewak djspiewak merged commit 7fbcc20 into typelevel:series/1.x Apr 30, 2019
@kubukoz kubukoz deleted the clear-up-resource branch April 30, 2019 14:45
@kubukoz kubukoz mentioned this pull request May 2, 2019
Merged
@kubukoz kubukoz mentioned this pull request Dec 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubukoz @codecov-io @djspiewak @rossabaker