Upgrade to cats-1.0.0-RC1 and more #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
force-pushed
the
cats-1.0.0-RC1
branch
from
b88b884
to
32dd06b
Compare
rossabaker
commented
Oct 31, 2017
| @@ -152,7 +152,7 @@ private[effect] trait SyncInstances { | |||
|
|
|||
| // overwriting the pre-existing one, since flatMap is guaranteed stack-safe | |||
| def tailRecM[A, B](a: A)(f: A => StateT[F, S, Either[A, B]]): StateT[F, S, B] = | |||
| StateT.catsDataMonadForStateT[F, S].tailRecM(a)(f) | |||
| IndexedStateT.catsDataMonadForIndexedStateT[F, S].tailRecM(a)(f) | |||
There was a problem hiding this comment.
I have not spent any time whatsoever considering whether the instances can be generalized to IndexedStateT. This is minimal to make it compile.
There was a problem hiding this comment.
I'm fine sticking with this for the time being. It seems likely that we'll be able to generalize a bit, but it'll take some looking.
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 84.95% 84.95%
=======================================
Files 18 18
Lines 359 359
Branches 23 23
=======================================
Hits 305 305
Misses 54 54 |
alexandru
approved these changes
Oct 31, 2017
mpilquist
approved these changes
Nov 1, 2017
|
👍, thanks! (I'll need this for catbird, which I'll need for iteratee.io, which I'll need for circe, etc.). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades: