Change abstract instance vals to defs #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
Feb 9, 2023
build.sbt
Outdated
Comment on lines
38
to
40
| libraryDependencies += "org.typelevel" %%% "cats-core" % CatsVersion | ||
| libraryDependencies += "org.typelevel" %%% "cats-core" % CatsVersion, | ||
| libraryDependencies += "org.typelevel" %%% "cats-effect" % "3.4.5", | ||
|
|
There was a problem hiding this comment.
Adding CE would make a circular dependency. Also, why? 🤔
There was a problem hiding this comment.
Because this was my initial playground experimenting with IOLocal and I didn't clean up after myself.
[hangs head in shame]
armanbilge
approved these changes
Feb 9, 2023
|
I'll wait a bit for an official maintainer since this one is more consequential than a README change. (Specifically: I don't think we can go back if Arman and I are deemed wrong.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264. I standardized on def: there are more of those, and MiMa seems okay with it.