Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repeat Parser until end Parser #146

Merged
merged 3 commits into from Jan 11, 2021
Merged

Add repeat Parser until end Parser #146

merged 3 commits into from Jan 11, 2021

Conversation

regadas
Copy link
Collaborator

@regadas regadas commented Jan 10, 2021

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 10, 2021 •
edited

Codecov Report

Merging #146 (ad39395) into main (0b29f1a) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   95.59%   95.73%   +0.14%     
==========================================
  Files           7        7              
  Lines         930      938       +8     
  Branches       90       82       -8     
==========================================
+ Hits          889      898       +9     
+ Misses         41       40       -1
Impacted Files Coverage Δ
core/shared/src/main/scala/cats/parse/Parser.scala 95.34% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b29f1a...ad39395. Read the comment docs.

@regadas regadas changed the title Add parser Parser until end Parser Add parse Parser until end Parser Jan 10, 2021
@regadas regadas changed the title Add parse Parser until end Parser Add repeat Parser until end Parser Jan 10, 2021
johnynek
johnynek reviewed Jan 10, 2021
View reviewed changes
Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of renaming these method repUntil? That will help with autocomplete and emphasize that there is a repetition going on.

core/shared/src/main/scala/cats/parse/Parser.scala Outdated Show resolved Hide resolved
core/shared/src/main/scala/cats/parse/Parser.scala Outdated Show resolved Hide resolved
johnynek
johnynek reviewed Jan 11, 2021
View reviewed changes
Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great except one minor issue.

core/shared/src/main/scala/cats/parse/Parser.scala Outdated Show resolved Hide resolved
johnynek
johnynek approved these changes Jan 11, 2021
View reviewed changes
Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johnynek johnynek merged commit fff9846 into typelevel:main Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnynek johnynek johnynek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@regadas @codecov-io @johnynek