Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json parse example #274

Merged
merged 1 commit into from Oct 4, 2021
Merged

Fix json parse example #274

merged 1 commit into from Oct 4, 2021

Conversation

zsluedem
Copy link
Contributor

@zsluedem zsluedem commented Oct 4, 2021

This pr is trying to fix #272.

Currently the example in the readme can not actually work very well

Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@codecov-commenter
Copy link

Codecov Report

Merging #274 (d366caf) into main (6fad586) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Current head d366caf differs from pull request most recent head fefde2d. Consider uploading reports for the commit fefde2d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
+ Coverage   96.12%   96.22%   +0.10%     
==========================================
  Files           8        8              
  Lines         980      980              
  Branches       93       93              
==========================================
+ Hits          942      943       +1     
+ Misses         38       37       -1     
Impacted Files Coverage Δ
core/shared/src/main/scala/cats/parse/Parser.scala 96.10% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fad586...fefde2d. Read the comment docs.

@zsluedem
Copy link
Contributor Author

zsluedem commented Oct 4, 2021

@johnynek Got some import error . Force push already.

@johnynek johnynek merged commit c1f7ffc into typelevel:main Oct 4, 2021
@zsluedem zsluedem deleted the fix-example branch October 4, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme example does not parse
3 participants