Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soft.with1.between and surroundedBy #290

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

johnynek
Copy link
Collaborator

this was overlooked in #289

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2021

Codecov Report

Merging #290 (2312d27) into main (0039bb2) will increase coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   95.98%   96.49%   +0.50%     
==========================================
  Files           8        8              
  Lines         997      999       +2     
  Branches       88       88              
==========================================
+ Hits          957      964       +7     
+ Misses         40       35       -5     
Impacted Files Coverage Δ
core/shared/src/main/scala/cats/parse/Parser.scala 96.43% <100.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0039bb2...2312d27. Read the comment docs.

@johnynek johnynek requested a review from regadas October 30, 2021 02:31
Copy link
Collaborator

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! nice catch @johnynek!

@regadas regadas merged commit 31df9e8 into main Nov 1, 2021
@regadas regadas deleted the oscar/add_soft_with1_between branch November 1, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants