Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure void is idempotent #297

Merged
merged 1 commit into from Nov 10, 2021
Merged

Make sure void is idempotent #297

merged 1 commit into from Nov 10, 2021

Conversation

johnynek
Copy link
Collaborator

@johnynek johnynek commented Nov 6, 2021

This adds a law (that actually already passed), and makes unmap a bit more precise in the case of Defer.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021

Codecov Report

Merging #297 (857126a) into main (eea17fa) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   96.24%   96.53%   +0.29%     
==========================================
  Files           8        8              
  Lines        1011     1011              
  Branches       81       81              
==========================================
+ Hits          973      976       +3     
+ Misses         38       35       -3     
Impacted Files Coverage Δ
core/shared/src/main/scala/cats/parse/Parser.scala 96.44% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea17fa...857126a. Read the comment docs.

@johnynek johnynek requested a review from regadas November 9, 2021 02:22
Copy link
Collaborator

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@regadas regadas merged commit 714a9df into main Nov 10, 2021
@regadas regadas deleted the oscar/idempotent_unmap branch November 10, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants