Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mima exclusion #302

Merged
merged 1 commit into from Nov 12, 2021
Merged

Remove mima exclusion #302

merged 1 commit into from Nov 12, 2021

Conversation

johnynek
Copy link
Collaborator

By putting the call to makeError inside Eval.later we can avoid the mima exclusion, which simplifies the build.

This is in preparation for publishing a new version hopefully today.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #302 (d433bab) into main (a0ec067) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   96.34%   96.53%   +0.19%     
==========================================
  Files           8        8              
  Lines        1011     1010       -1     
  Branches       81       81              
==========================================
+ Hits          974      975       +1     
+ Misses         37       35       -2     
Impacted Files Coverage Δ
core/shared/src/main/scala/cats/parse/Parser.scala 96.43% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0ec067...d433bab. Read the comment docs.

Copy link
Collaborator

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@regadas regadas merged commit d70d903 into main Nov 12, 2021
@regadas regadas deleted the oscar/remove_mima_exclusion branch November 12, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants