-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast charIn for ranges like 'A' to 'Z' #360
Conversation
22288d9
to
4080506
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments.
The tests failed but I didn't quite see the error yet, but I think there likely is one.
Also, master got a fix for a CI check that would have also likely failed for you. Please merge master if you can.
Thanks again for the PR!
4080506
to
f78db88
Compare
f78db88
to
b146a51
Compare
Codecov Report
@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 96.54% 96.56% +0.01%
==========================================
Files 9 9
Lines 1130 1135 +5
Branches 111 108 -3
==========================================
+ Hits 1091 1096 +5
Misses 39 39
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
No description provided.