Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast charIn for ranges like 'A' to 'Z' #360

Merged
merged 4 commits into from
Feb 10, 2022

Conversation

Odomontois
Copy link
Contributor

No description provided.

@Odomontois Odomontois force-pushed the parser-range branch 3 times, most recently from 22288d9 to 4080506 Compare January 27, 2022 15:12
Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you!

Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments.

The tests failed but I didn't quite see the error yet, but I think there likely is one.

Also, master got a fix for a CI check that would have also likely failed for you. Please merge master if you can.

Thanks again for the PR!

core/shared/src/test/scala/cats/parse/ParserTest.scala Outdated Show resolved Hide resolved
core/shared/src/test/scala/cats/parse/ParserTest.scala Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022

Codecov Report

Merging #360 (ca37e10) into main (82ef549) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   96.54%   96.56%   +0.01%     
==========================================
  Files           9        9              
  Lines        1130     1135       +5     
  Branches      111      108       -3     
==========================================
+ Hits         1091     1096       +5     
  Misses         39       39              
Impacted Files Coverage Δ
core/jvm/src/main/scala/cats/parse/BitSet.scala 82.35% <100.00%> (+2.35%) ⬆️
core/shared/src/main/scala/cats/parse/Parser.scala 96.60% <100.00%> (+0.12%) ⬆️
...shared/src/main/scala/cats/parse/Accumulator.scala 97.56% <0.00%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ef549...ca37e10. Read the comment docs.

core/shared/src/main/scala/cats/parse/Parser.scala Outdated Show resolved Hide resolved
core/jvm/.github/workflows/clean.yml Outdated Show resolved Hide resolved
core/jvm/.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@johnynek johnynek merged commit 371bd61 into typelevel:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants