Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RadixNode.matchAt #362

Merged
merged 1 commit into from Jan 29, 2022
Merged

Fix RadixNode.matchAt #362

merged 1 commit into from Jan 29, 2022

Conversation

johnynek
Copy link
Collaborator

followup to #352 to fix an issue only noticed on second review.

Added a test on Parser first that failed, then fixed the bug.

@johnynek johnynek requested a review from regadas January 28, 2022 05:15
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022

Codecov Report

Merging #362 (e04b9c9) into main (828ff4b) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   96.63%   96.71%   +0.08%     
==========================================
  Files           9        9              
  Lines        1128     1128              
  Branches       99      111      +12     
==========================================
+ Hits         1090     1091       +1     
+ Misses         38       37       -1     
Impacted Files Coverage Δ
...e/shared/src/main/scala/cats/parse/RadixNode.scala 95.31% <100.00%> (ø)
core/shared/src/main/scala/cats/parse/Parser.scala 96.69% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828ff4b...e04b9c9. Read the comment docs.

@regadas regadas merged commit 254ca7a into main Jan 29, 2022
@regadas regadas deleted the oscar/fix_match_at branch January 29, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants