Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvement to cheapOneOf0 #400

Merged
merged 1 commit into from Mar 28, 2022
Merged

Conversation

johnynek
Copy link
Collaborator

We were potentially hiding a OneOf by not carefully checking if each argument might be a Parser.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #400 (1b7c7fe) into main (fe8adc5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
+ Coverage   96.72%   96.73%   +0.01%     
==========================================
  Files           9        9              
  Lines        1284     1288       +4     
  Branches      124      133       +9     
==========================================
+ Hits         1242     1246       +4     
  Misses         42       42              
Impacted Files Coverage Δ
core/shared/src/main/scala/cats/parse/Parser.scala 96.44% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe8adc5...1b7c7fe. Read the comment docs.

@johnynek johnynek merged commit 7856e98 into main Mar 28, 2022
@johnynek johnynek deleted the oscar/improve_cheap_one_of branch March 28, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants